Added support for new macromeasures opt
#24
Conversation
| @@ -159,6 +160,16 @@ fullcontact.person.email('foo@bar.com', 1, function (err, data) { | |||
| }); | |||
| ``` | |||
|
|
|||
|
|
|||
| The `Person` API's now accept the `macromeasures` param as a boolean | |||
There was a problem hiding this comment.
I would put this behind the webhook stuff just so that the arguments make more sense when reading for the first time.
It is also more likely people are looking for webhooks then the premium features I think
|
Thanks for the feedback @AdriVanHoudt |
| The `Person` API's now accept the `macromeasures` param as a boolean | ||
|
|
||
| ```js | ||
| fullcontact.person.email('opensource@observe.it', null, null, null, null, null, true, function (err, data) { |
There was a problem hiding this comment.
Not related to this PR, but maybe we should start using an object instead of null, null, null, null, true for API. This is getting really verbose and unreadable. Thoughs @AdriVanHoudt ?
There was a problem hiding this comment.
Maybe something like
fullcontact.person.email('email@adr.ess', {
macromeasures: true,
webhookId:'id here'
}, fn);There was a problem hiding this comment.
Totally agree! ^^. Would that be a new Major version increment?
There was a problem hiding this comment.
@GitTristan since the api would be totally different and therefore cause everything to break, yes it would be a major version change
There was a problem hiding this comment.
Going to merge this and open an issue for the new api
Added new opt
Updated README
Added new test
Tests pass
Tested our calling code and new opt works on forked version and returns new .macromeasures prop containing .interests, etc
https://www.fullcontact.com/developer/docs/person/#premium-features
Let me know if you need anything further for the PR
Thanks,