Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xb.get_bitinformation(implementation="julia/python") yields different results #155

Closed
aaronspring opened this issue Oct 23, 2022 · 2 comments · Fixed by #156
Closed

xb.get_bitinformation(implementation="julia/python") yields different results #155

aaronspring opened this issue Oct 23, 2022 · 2 comments · Fixed by #156
Labels
bug Something isn't working

Comments

@aaronspring
Copy link
Collaborator

aaronspring commented Oct 23, 2022

  • xbitinfo version: main
  • Python version: binder
  • Operating System: binder

Description

What I Did

ds = xr.tutorial.load_dataset("eraint_uvz")
xb.get_bitinformation(ds, dim="longitude", implementation="python")
xb.get_bitinformation(ds, dim="longitude", implementation="julia")
@aaronspring aaronspring added the bug Something isn't working label Oct 23, 2022
@aaronspring
Copy link
Collaborator Author

also weird

ds = xr.tutorial.load_dataset("air_temperature")
xb.get_bitinformation(ds, dim="lon").dims # Frozen({'bit32': 32})
xb.get_bitinformation(ds, dim="lon", implementation="python").dims # Frozen({'bit64': 64})

@observingClouds
Copy link
Owner

observingClouds commented Oct 23, 2022

Thanks for pointing this out. Currently, since set_zero_insignificant is not implemented for the python version, the following should be true:

ds = xr.tutorial.load_dataset("eraint_uvz")
xb.get_bitinformation(ds, dim="longitude", implementation="python", set_zero_insignificant=False)
xb.get_bitinformation(ds, dim="longitude", implementation="julia", set_zero_insignificant=False, masked_value=None)

However, this also fails currently. Still very much work-in-progress.

EDIT: masked_value needs to be set to None, because masked_value is not yet implemented in the python version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants