Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pythonic bitinformation #126

Merged
merged 22 commits into from Oct 21, 2022
Merged

Pythonic bitinformation #126

merged 22 commits into from Oct 21, 2022

Conversation

observingClouds
Copy link
Owner

@observingClouds observingClouds commented Aug 21, 2022

This is work-in-progress for a pythonic way to retrieve the mutual information content.

@observingClouds
Copy link
Owner Author

This branch is now in a state where the basic functionality of get_bitinformation is ported to python and works in first tests reasonably well with Dask. Due to #98 and other issues with the wrapping of Julia code, large datasets could not be processed straight forward. Ideally, Julia and python would work better together in the future, but currently this seems to be a reasonable alternative.

However, the following features are still missing in the python implementation and should be added in a next step:

  • enable masked values
  • enable set_zero_insignificant (currently is set to False for the python implementation)
  • any additional arguments to xb.get_bitinformation

Copy link
Collaborator

@aaronspring aaronspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Wasn’t expecting to see identical result from Julia and pythonic implementation. The main issue I see is that this means duplication of bitinformation.jl, I.e. each change there should be done here as well. On the other hand we could make julia and bitinformation.jl an optional install.

@observingClouds
Copy link
Owner Author

I second that the duplication is not ideal and I would like to avoid it, but currently it seems (at least to me) the easiest way to allow for larger datasets.

@aaronspring
Copy link
Collaborator

julia stays the default.

@observingClouds
Copy link
Owner Author

julia stays the default.

Yes!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants