New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keep attrs of get_bitinformation #158
Conversation
d7e77d5
to
754191b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please explain why you would like to have the original units
and long_name
from the dataset? Do we loose these attributes when writing to netCDF/zarr?
The unit of the data that info_per_bit = xb.get_bitinformation(ds)
contains is 1
and not e.g. ms-1
if the input data was wind speed.
I want to keep long_name and all other attrs for context. Now we only have the variable name and no context from the input data. Original unit might not be very important |
The attributes are preserved in
|
I know. I just refered to info_per_bit the output from get_bitinformation |
I don't really like this PR yet, mainly because the |
I like the source idea |
closes #154
units
tobitinfo_units
long_name
tobitinfo_long_name