New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiling list of Plugins with issues seeking help #285
Conversation
Thanks very much indeed for doing this! I've been wanting to find out about the GitHub API for ages, so I decided to use running this script as a way to start learning about it. I was able to get a GitHub Access token, and your note about no permissions being needed was helpful. When I ran it, I got lots of output of the form:
|
What system are you running this on? |
Thanks. I'm on Mac, and I am running it with a PyCharm terminal window... I'll try it again, from outside of PyCharm, and see what happens. |
Wow - here is an example of the current output file that is generated: 🎉 |
I did get the same result in an ordinary terminal window, but in fairness, it does contain a link to further info, so I will make time to read that: |
Looking at the headings in the file it generates, I see that it currently finds issues with Documentation and Good first issue, but no Help Wanted, although it does search for that label... Ah no, my mistake. I saw just the two level-2 headings, and didn't realise that the level-1 "Help wanted" heading is the heading for the "help wanted" list... |
Wow there's a lot of issues with cryptic summaries! |
Thanks for pointing that out, this is not intended. |
I think we should add at least the plugin name, maybe even more, to the output |
I think that's a great idea. I feel like you've solved 90% of the problem - and probably 90% of the discussion (on formatting and structure of the output) is still to come to come 🤣 |
I really liked that you put this at the top of the file: %% do not edit this file %% |
In the todo list at the top of the issue, I think it's probably worth including a note to decide on some descriptive text at the top of the file... |
In case somebody stumbles onto the note on its own? |
Yes...
That sounds good. |
I have added some text and a GH action, the only thing left is deciding where the output file ends up, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This review is by both me and @chrisgrieser ...
Huge thanks for this - the descriptive text is really improved!
Our recommendations:
- The output file should be put in
01 - Community
in a new sub-folder calledContributing to the Community
. - Please could the output file be called
Plugins seeking help.md
As a separate step, we can move the Volunteers page there too.
We're comfortable running the GitHub Action daily - if one doesn't get merged before the next run, the earlier one can always be closed...
Adressed those comments, and I think this pr is ready for review. Once this is merged I would like a test run of the action. |
@joethei Thanks for making those changes! I see you merged in from main, and that has brought in the new requirement that python code has type-hints (and so the python build failed) Do you have experience with python type hints already? If not, as the person who set up the requirement, I don't mind adding them to the code on your branch... |
Not with python, but from what I have seen so far this seems easy enough. |
Thanks... to test on your machine, you should be able to run |
Types hints have been added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is great!
Added
A script that retrieves all issues with the labels
documentation
,help wanted
, andgood first issue
.As discussed here: https://discord.com/channels/686053708261228577/915679988118863933/937297550044708934
To test this you can run the
update_issues.py
scriptYou need a github api key in the
apikey
parameter, the api key does not need any permissions, just needs to exists to not hit any rate limits.The current implementation would hit the rate limit once there are around 1.666 plugins.
ToDo
Checklist
.md
extension