Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Volunteer Plugin Doc Writers #273

Merged
merged 3 commits into from Feb 14, 2022
Merged

Conversation

AB1908
Copy link
Contributor

@AB1908 AB1908 commented Jan 30, 2022

Added

A volunteer docs page as discussed on Discord: https://discord.com/channels/686053708261228577/840286238928797736/936621649829199923

Checklist

@claremacrae
Copy link
Contributor

A note to reviewers:

  • I wonder whether the title "Volunteer Plugin Doc Writers" might be clearer?
  • I don't know if it matters that there's no metadata at the top of the file...

Copy link
Contributor

@claremacrae claremacrae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checks have pointed out that there is no .md file extension on this file...

If you know how, please could you rename it to fix that?

Many thanks

@AB1908
Copy link
Contributor Author

AB1908 commented Jan 30, 2022

I dunno how I missed something like that. I made a few of the changes but have left it with no metadata.

@claremacrae claremacrae changed the title Create Volunteer Doc Writers Create Volunteer Plugin Doc Writers Jan 30, 2022
@argenos
Copy link
Contributor

argenos commented Feb 11, 2022

@claremacrae I believe you need to approve since you requested changes last time

Copy link
Contributor

@claremacrae claremacrae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@argenos I'll approve this, because I cannot see how to now apply the suggested edit that I made previously, which was to fix a typo:
You can reach out the the plugin developer
->
You can reach out to the plugin developer

I'm too tired - it took me about 4 goes to get those words right this time round!

06 - Inbox/Volunteer Plugin Doc Writers.md Outdated Show resolved Hide resolved
@claremacrae
Copy link
Contributor

Thanks for fixing the file extension! :-)

Co-authored-by: Clare Macrae <github@cfmacrae.fastmail.co.uk>
@claremacrae claremacrae merged commit d81e4e4 into obsidian-community:main Feb 14, 2022
@claremacrae
Copy link
Contributor

Merged - thank you very much @AB1908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants