-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update existing people, plugin and theme pages #216
Conversation
@@ -10,7 +10,7 @@ publish: true | |||
|
|||
- GitHub: [avr](https://github.com/avr/) ^github | |||
<!-- - Discord: `@` ^discord--> | |||
<!-- - Website: <> ^website--> | |||
- Website: <https://github.com/avr> ^website |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That‘s the same as the GitHub address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot.
This case
The update-releases.py
script gathers author Urls from the authorUrl
values in all the manifest.json files in the author's plugins.
It then picks one of them, and uses that.
I checked, and avr
has one plugin currently. Its manifest has this line:
"authorUrl": "https://github.com/avr"
Which they must have added since the page was first created.
So I think that this change reflects the author's intent.
Other cases
As an aside, not all plugin authors use that field consistently across all their repos... there are a few prolific plugin authors who put the Plugin's Url in the authorUrl field. This means that as they add new plugins, the generated url changes... and it's the (undocumented) convention of this project to revert those scripted edits...
The attached file shows all the author URLs that point in to GitHub.com:
github-account-as-author-url.txt
I created that file with:
cd obsidian-hub/01 - Community/People
cat * | grep Website: | sort | uniq | grep github > github-account-as-author-url.txt
# then manually pruning out a few GitHub pages links and similar (looks like a few stray GitHub.io link got missed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added #217 as a way of preventing the need for this manual step:
and it's the (undocumented) convention of this project to revert those scripted edits...
Hi @kometenstaub - do you have any thoughts on this? |
Looks good. |
Edited
update-releases.py
to update existing notes.Checklist
Not applicable