Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename/restructure image_suffixes mechanism #28

Closed
Tracked by #137
dwrolvink opened this issue Feb 6, 2022 · 0 comments
Closed
Tracked by #137

Rename/restructure image_suffixes mechanism #28

dwrolvink opened this issue Feb 6, 2022 · 0 comments
Labels
technical debt The code works, but is confusing, error prone, or just not optimal

Comments

@dwrolvink
Copy link
Collaborator

To discern between image tags and note inclusions, the image_suffixes list is now used to check what suffix a link has.

#26 added pdf to the list, which is not an image. This can be confusing in the future.

  • Rename image_suffixes to something more sensible
  • Move this list to the config yaml so that further code changes are not neccessary in the future
  • Add documentation
@dwrolvink dwrolvink added good first issue technical debt The code works, but is confusing, error prone, or just not optimal labels Feb 6, 2022
@dwrolvink dwrolvink mentioned this issue Feb 13, 2022
Closed
15 tasks
dwrolvink added a commit to dwrolvink/obsidian-html that referenced this issue Feb 16, 2022
@dwrolvink
implements obsidian-html#28
74d9984
dwrolvink added a commit that referenced this issue Feb 16, 2022
@dwrolvink
Merge pull request #159 from dwrolvink/master
65c5e82 
implements #28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical debt The code works, but is confusing, error prone, or just not optimal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dwrolvink