Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap localStorage calls #352

Closed
dwrolvink opened this issue Aug 31, 2022 · 0 comments
Closed

Wrap localStorage calls #352

dwrolvink opened this issue Aug 31, 2022 · 0 comments
Labels
enhancement New feature or request is accepted and will be worked on low priority We'll get to it when we get to it
Milestone
v3.4.0

Comments

@dwrolvink
Copy link
Collaborator

Turns out that if a user blocks cookies on chrome that localStorage is also blocked. We don't need cookies, but things qill break when localStorage is not available. There are alternatives for that though,so these should be used when localStorage is not available.
@dwrolvink dwrolvink added the enhancement New feature or request is accepted and will be worked on label Aug 31, 2022
@dwrolvink dwrolvink added the low priority We'll get to it when we get to it label Sep 28, 2022
dwrolvink added a commit to dwrolvink/obsidian-html that referenced this issue Nov 13, 2022
@dwrolvink
implement obsidian-html#352 wrap localstorage calls
cf28c37
@dwrolvink dwrolvink added this to the v3.3.0+ milestone Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request is accepted and will be worked on low priority We'll get to it when we get to it
Projects
None yet
Milestone
v3.4.0
Development

No branches or pull requests
1 participant
@dwrolvink