Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] For tables containing images, click to preview image in full size #728

Closed
blacklightpy opened this issue May 25, 2023 · 1 comment
Labels
enhancement New feature or request is accepted and will be worked on fixed in master
Milestone

Comments

@blacklightpy
Copy link

This is helpful for images in tables, which can be too small to see. Currently on PC, Ctrl+clicking the image does not open it in a new tab. Right clicking and opening each image is not ideal.

Another implementation idea:
Tables with images need not restrict content width, and should be able to overflow towards the right.

@dwrolvink dwrolvink added the low priority We'll get to it when we get to it label Jul 9, 2023
dwrolvink added a commit to dwrolvink/obsidian-html that referenced this issue Jul 9, 2023
@dwrolvink dwrolvink added enhancement New feature or request is accepted and will be worked on fixed in master and removed low priority We'll get to it when we get to it labels Jul 9, 2023
@dwrolvink
Copy link
Collaborator

The tables overflowing to the right was the original behavior, but some users had issue with this, and it is not the obsidian behavior, which limits the screen width, so we decided to move to a fixed-width table, which is honestly also pretty much the standard when it comes to tables.

I did add in some js code that wraps any image in the note container in a link that points to its own src, so you can click and get the original size in a different tab.

This functionality is disabled when the image is already wrapped by a link element, because otherwise you'd get different behavior in the webpage than in obsidian.

@dwrolvink dwrolvink added this to the v4.0.0 milestone Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request is accepted and will be worked on fixed in master
Projects
None yet
Development

No branches or pull requests

2 participants