Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out ConvertFullWindowsPathToRelativeMarkdownPath() #9

Closed
dwrolvink opened this issue Oct 8, 2021 · 1 comment
Closed

Factor out ConvertFullWindowsPathToRelativeMarkdownPath() #9

dwrolvink opened this issue Oct 8, 2021 · 1 comment

Comments

@dwrolvink
Copy link
Collaborator

Related to the fix of #8

  • Factor out ConvertFullWindowsPathToRelativeMarkdownPath() in favor of using pathlib standard methods.
  • Standardize variable naming and use of Path vs string paths e.g.
    • rel_path vs relative_path
    • _path always being a Path('').resolve() object
    • *_path_posix for strings in the a/b/file.md format
    • etc
@dwrolvink
Copy link
Collaborator Author

As of dwrolvink@bc13459

  • Path usage / variable naming more standardized
  • ConvertFullWindowsPathToRelativeMarkdownPath removed

good enough for now, incorrect path varnaming to be corrected in the future whenever encountered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dwrolvink