-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completion date and recurrence not being applied to task when selecting any "DONE" indicator from drop down status menu in modal #1590
Comments
Hi @gypsyav, thanks for logging this. Yes, you are correct, it's a known and documented limitation: There simply wasn't time to implement this before releasing the new statuses, and I felt it was better to release the new features that were already working, as it would already be useful to many people. Updating the dialog will actually be a highly non-trivial feature to implement, and will need a lot of thinking about all the various states that the data in the modal can go through. For example, what if the task was DONE when the dialog was opened, then the user switched the status to TODO, so the Done Date would be removed from the modal - but then the user turned it back to DONE again. Should the Done date be the original one which should be remembered, or should it be the new one? |
Thanks for the explanation. I should have read the docs. :) Thanks for all the work you do on this plugin. |
No, it's OK, I'm glad you logged it - I had been meaning to, and you kindly saved me the time! |
Apologies that this is still not fixed. Some recent PRs have moved the code a little in the direction where a fix becomes manageable... However, my first attempt at fixing it this evening was not successful. So I have, for now, at least implemented the alternative request of adding a warning in the modal about this limitation.
|
Please check that this issue hasn't been reported before.
Expected Behavior
When selecting any status indicator in the drop down list that indicates a task is done a completion date should be added to the task and for recurring tasks a new recurrence should be triggered.
Current behaviour
When using the status drop down to mark a task the task does not get a completion date added and a recurrence is not triggered.
Steps to reproduce
Bring up the tasks modal and select a DONE status from the drop down list instead of checking the box.
Which Operating Systems are you using?
Obsidian Version
1.1.9
Tasks Plugin Version
1.23
Checks
Possible solution
No response
The text was updated successfully, but these errors were encountered: