Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion date and recurrence not being applied to task when selecting any "DONE" indicator from drop down status menu in modal #1590

Closed
2 of 7 tasks
gypsyav opened this issue Jan 26, 2023 · 5 comments · Fixed by #2686
Labels
scope: edit task The Create or edit task modal/dialog scope: recurrence Anything to do with recurring/repeating tasks scope: task states Requests relating to custom task states, like 'in-progress', for example, and state transitions type: bug Something isn't working

Comments

@gypsyav
Copy link

gypsyav commented Jan 26, 2023

Please check that this issue hasn't been reported before.

  • I searched previous Bug Reports didn't find any similar reports.

Expected Behavior

When selecting any status indicator in the drop down list that indicates a task is done a completion date should be added to the task and for recurring tasks a new recurrence should be triggered.

Current behaviour

When using the status drop down to mark a task the task does not get a completion date added and a recurrence is not triggered.

Steps to reproduce

Bring up the tasks modal and select a DONE status from the drop down list instead of checking the box.

Which Operating Systems are you using?

  • Android
  • iPhone/iPad
  • Linux
  • macOS
  • Windows

Obsidian Version

1.1.9

Tasks Plugin Version

1.23

Checks

  • I have tried it with all other plugins disabled and the error still occurs

Possible solution

No response

@gypsyav gypsyav added the type: bug Something isn't working label Jan 26, 2023
@claremacrae
Copy link
Collaborator

Hi @gypsyav, thanks for logging this.

Yes, you are correct, it's a known and documented limitation:
https://obsidian-tasks-group.github.io/obsidian-tasks/getting-started/create-or-edit-task/#status

image

There simply wasn't time to implement this before releasing the new statuses, and I felt it was better to release the new features that were already working, as it would already be useful to many people.

Updating the dialog will actually be a highly non-trivial feature to implement, and will need a lot of thinking about all the various states that the data in the modal can go through.

For example, what if the task was DONE when the dialog was opened, then the user switched the status to TODO, so the Done Date would be removed from the modal - but then the user turned it back to DONE again. Should the Done date be the original one which should be remembered, or should it be the new one?

@claremacrae claremacrae added scope: user interface Changes to parts of UI other the Edit task modal. See also "scope: edit task" scope: task states Requests relating to custom task states, like 'in-progress', for example, and state transitions labels Jan 26, 2023
@gypsyav
Copy link
Author

gypsyav commented Jan 27, 2023

Thanks for the explanation. I should have read the docs. :)

Thanks for all the work you do on this plugin.

@claremacrae
Copy link
Collaborator

Thanks for the explanation. I should have read the docs. :)

No, it's OK, I'm glad you logged it - I had been meaning to, and you kindly saved me the time!

@claremacrae claremacrae changed the title Completion date not being added to task when selecting any "DONE" indicator from drop down status menu in modal Completion date and recurrence not being applied to task when selecting any "DONE" indicator from drop down status menu in modal Mar 2, 2023
@claremacrae claremacrae added the scope: recurrence Anything to do with recurring/repeating tasks label Mar 2, 2023
@claremacrae claremacrae added scope: edit task The Create or edit task modal/dialog and removed scope: user interface Changes to parts of UI other the Edit task modal. See also "scope: edit task" labels Jul 24, 2023
@claremacrae
Copy link
Collaborator

Apologies that this is still not fixed. Some recent PRs have moved the code a little in the direction where a fix becomes manageable... However, my first attempt at fixing it this evening was not successful.

So I have, for now, at least implemented the alternative request of adding a warning in the modal about this limitation.

@claremacrae
Copy link
Collaborator

This is now fixed, and will be included in the next Tasks release.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: edit task The Create or edit task modal/dialog scope: recurrence Anything to do with recurring/repeating tasks scope: task states Requests relating to custom task states, like 'in-progress', for example, and state transitions type: bug Something isn't working
Projects
Status: Features - Later release
Status: 🎉 Released
2 participants