Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing hidden components classes in HTML code #1866

Closed
3 of 7 tasks
TomWol opened this issue Apr 11, 2023 · 2 comments · Fixed by #1908
Closed
3 of 7 tasks

Missing hidden components classes in HTML code #1866

TomWol opened this issue Apr 11, 2023 · 2 comments · Fixed by #1908
Labels
question Further information is requested scope: css styling Changes to styling of elements displayed by Tasks, including search results and individual tasks type: bug Something isn't working

Comments

@TomWol
Copy link

TomWol commented Apr 11, 2023

Please check that this issue hasn't been reported before.

  • I searched previous Bug Reports didn't find any similar reports.

Expected Behavior

Using the new Tasks themability, merged from #1519, when using hide in a Tasks query, I expect the ul element to generate classes that show this, as referenced in the 'Hidden components' section in the documention.

Current behaviour

Not all hidden components added via hide are represented in the code, for example hide backlink does not generate a tasks-layout-hide-backlink class the way a hide due date generates tasks-layout-hide-dueDate for the ul element...

These are really convenient for intelligently adapting and compacting a grid layout like the one provided in the docs.

Steps to reproduce

Use hide backlink (for example) in a Tasks query and observe the HTML code via Developer Tools in Obsidian.

Which Operating Systems are you using?

  • Android
  • iPhone/iPad
  • Linux
  • macOS
  • Windows

Obsidian Version

1.2.2

Tasks Plugin Version

3.1.0

Checks

  • I have tried it with all other plugins disabled and the error still occurs

Possible solution

I would like to see them added.

Additionally, I wonder if these should also use data-attributes rather than classes, the way data-task-group-by is aswell, a data-task-hidden or data-task-hide or something... Interested to see what you come up with, @esm7!

@TomWol TomWol added the type: bug Something isn't working label Apr 11, 2023
@esm7
Copy link
Contributor

esm7 commented Apr 11, 2023

You're right, it seems like the code for hiding urgency, backlinks and the edit button (basically the things that are part of a query and not the task itself) are set in a different place in the code, and I missed them in my refactor. Will fix.

@claremacrae
Copy link
Collaborator

Steps to reproduce

Use hide backlink (for example) in a Tasks query and observe the HTML code via Developer Tools in Obsidian.

Hi @TomWol Thanks for logging.

Please could you kindly have a read of this:
https://publish.obsidian.md/tasks/Support+and+Help/Report+a+Bug#Give+steps+to+reproduce+the+bug

And then adjust the Steps to reproduce accordingly.

Many thanks.

@claremacrae claremacrae added question Further information is requested scope: css styling Changes to styling of elements displayed by Tasks, including search results and individual tasks labels Apr 11, 2023
esm7 added a commit to esm7/obsidian-tasks that referenced this issue Apr 23, 2023
claremacrae pushed a commit that referenced this issue Apr 24, 2023
* Fixes query-related fields not having a "hidden" class:
#1866

* A small fix to the manual testing guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested scope: css styling Changes to styling of elements displayed by Tasks, including search results and individual tasks type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants