Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview when hovering over backlinks no longer works as of ver 3.4.0 or later #2127

Open
3 of 7 tasks
gypsyav opened this issue Jul 14, 2023 · 15 comments
Open
3 of 7 tasks
Labels
scope: backlinks Anything to do with the backlinks displayed in task lists type: bug Something isn't working

Comments

@gypsyav
Copy link

gypsyav commented Jul 14, 2023

Please check that this issue hasn't been reported before.

  • I searched previous Bug Reports didn't find any similar reports.

Expected Behavior

When hovering over a link in a task query it should show a preview window when the core plugin Page Preview is enabled.

Current behaviour

Previews do not show up.

Steps to reproduce

  1. Create a new, empty vault
  2. Add and enable Tasks, from the Community Plugins store
    • The bug appears from Tasks 3.4.0 onwards, but just download the current version, as normal (so long as this issue is still open)
  3. Create a new file called File 1
  4. Add the following content to File 1
# File 1

- [ ] Task in File 1

  1. Create a new file called File 2
  2. Add the following content to File 2
# File 2

[[File 1]] - hovering over this link should preview the contents of `File 1`.

```tasks
```

  1. In File 2, hover over the link to File 1, and confirm that you can see a preview of File 1's contents.
  2. In File 2, hover over the backlink in the Task query block results, and confirm that there is no preview of File 1 shown.

Which Operating Systems are you using?

  • Android
  • iPhone/iPad
  • Linux
  • macOS
  • Windows

Obsidian Version

1.3.5

Tasks Plugin Version

10.2.0

Checks

  • I have tried it with all other plugins disabled and the error still occurs

Possible solution

This bug was introduced in ver 3.4.0

Backlink previews work correctly in ver 3.3.0 and before

@gypsyav gypsyav added the type: bug Something isn't working label Jul 14, 2023
@claremacrae
Copy link
Collaborator

Hi, thanks for logging it - please could there be a complete numbered list of steps in the reproduction, starting from 'empty vault, with just Tasks installed'....

@claremacrae claremacrae added scope: backlinks Anything to do with the backlinks displayed in task lists question Further information is requested labels Jul 14, 2023
@gypsyav
Copy link
Author

gypsyav commented Jul 15, 2023

I updated the steps above, though I'm not sure if that's what you wanted.

@claremacrae
Copy link
Collaborator

I updated the steps above, though I'm not sure if that's what you wanted.

Thanks - is the core plugin enabled by default, and with its settings not needing to be updated for hovering to just work?

@gypsyav
Copy link
Author

gypsyav commented Jul 15, 2023

In my test vault the Page Preview core plugin was enabled by default and the settings for it require pressing the ctrl/cmd key while hovering for everything except reading mode. Reading mode shows the preview just by hovering over the link.

@claremacrae
Copy link
Collaborator

Brilliant - thanks!

@claremacrae
Copy link
Collaborator

I’ve tested the repro, confirmed it does of course show the bug, and tweaked it a bit for ease of use.

@claremacrae claremacrae changed the title Preview when hovering over backlinks no longer works as of ver 3.4.0 Preview when hovering over backlinks no longer works as of ver 3.4.0 or later Jul 16, 2023
@claremacrae claremacrae removed the question Further information is requested label Jul 16, 2023
@datoner
Copy link

datoner commented Aug 18, 2023

Thank you @gypsyav for bringing this up. I'm also dearly missing the preview in my Tasks workflow. I hope it will get resolved soon. Anyway, thank you so much for this wonderful plugin @claremacrae!

@claremacrae
Copy link
Collaborator

@datoner best to upvote it with a 👍 then.

@claremacrae
Copy link
Collaborator

It's not exactly a fix, but in case it helps... Tasks 4.8.0, just released, now adds hyperlinks on group by backlinks headings... and hovering over those does show hover previews.

@Fendi168
Copy link

Fendi168 commented Nov 8, 2023

I still prefer the previous backlinks, which can be presented directly at the end of the task.I hope it can be resolved. Thank you

@datoner
Copy link

datoner commented Nov 8, 2023 via email

@claremacrae
Copy link
Collaborator

@datoner,

I created a workaround by adding my own backlink to the task description or using a backlink as a task description. I then use 'hide backlink' to hide the non functional one to keep it short and neat.

How did you do that?

@wjagers
Copy link

wjagers commented Nov 22, 2023

I guess the changes to QueryRenderer.ts in b97e103 are responsible?

@claremacrae
Copy link
Collaborator

I guess the changes to QueryRenderer.ts in b97e103 are responsible?

Yes that's right. That's the code from #1810, which fixed the following:

@claremacrae
Copy link
Collaborator

@wjagers If it's something you might be interesting in having a look at, I'd be happy to chat with you and show you the relevant bits of the code...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: backlinks Anything to do with the backlinks displayed in task lists type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants