Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent rare overwrite of wrong line in Reading mode & results blocks #1663

Merged
merged 2 commits into from
Feb 16, 2023
Merged

fix: Prevent rare overwrite of wrong line in Reading mode & results blocks #1663

merged 2 commits into from
Feb 16, 2023

Commits on Feb 15, 2023

  1. Implement guard on task write to file 

    Currently, the unique identifier (UID) for tasks
are a source file, a section, and an index into
the array of global-filter-matching tasks within
that section.

This diff does not change how tasks are uniquely
identified.

However, it does implement a guard when overwriting a
task in some file to ensure the line that is being
overwritten has similar content to the line that
was used to create the Task in the first place.

The world "similar" is used since the line is
permitted to have different content, so long as that
line represents a Task with identical data as per
the definition of Task.identicalTo
    @BluBloos
    BluBloos committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    6b7cefa View commit details
    Browse the repository at this point in the history

  2. Add useful error on replaceTaskWithTasks guard hit

    @BluBloos
    BluBloos committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    4a0554e View commit details
    Browse the repository at this point in the history