Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tooltip pop up above the description of task in short mode #1735

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

HynDuf
Copy link
Contributor

@HynDuf HynDuf commented Mar 7, 2023

Tooltip used to have mod-right animation which block the task text in short mode.

Fixes #1147

Description

Replace mod-right animation with pop-up. Basically just shift the tooltip up

Motivation and Context

Tooltip used to have mod-right animation which block the task text in short mode.
Sometimes, it is impossible to click the URL that was blocked by the tooltip.

How has this been tested?

Screenshots (if appropriate)

image

Types of changes

Changes visible to users:

  • Bug fix (prefix: fix - non-breaking change which fixes an issue)
  • New feature (prefix: feat - non-breaking change which adds functionality)
  • Breaking change (prefix: feat!! or fix!! - fix or feature that would cause existing functionality to not work as expected)
  • Documentation (prefix: docs - improvements to any documentation content)
  • Sample vault (prefix: vault - improvements to the Tasks-Demo sample vault)

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)
  • Infrastructure (prefix: chore - examples include GitHub Actions, issue templates)

Checklist

Terms

Tooltip used to have `mod-right` animation which block the task text in
short mode.

Fixes obsidian-tasks-group#1147
@claremacrae
Copy link
Collaborator

Thank you very much. I will test and merge this as soon as I have time - likely in a couple of days...

@claremacrae
Copy link
Collaborator

Assigning to me to review.

@claremacrae claremacrae self-assigned this Mar 9, 2023
Copy link
Collaborator

@claremacrae claremacrae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thank you very much.

I tried breaking it, like by massively increasing the font size. And it all worked fine.

@claremacrae claremacrae added the scope: css styling Changes to styling of elements displayed by Tasks, including search results and individual tasks label Mar 9, 2023
@claremacrae claremacrae merged commit 2c329f6 into obsidian-tasks-group:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: css styling Changes to styling of elements displayed by Tasks, including search results and individual tasks
Projects
Status: 🎉 Released
Development

Successfully merging this pull request may close these issues.

Floating tooltips would block the task text when short mode is on
2 participants