fix: Prevent exception if toggling in unsaved file in Reading mode #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the comment #1680 (comment) in #1680. If lines had been deleted from a file, and it was not yet saved when user then toggled a line near the end of the file in Reading mode, there could be an access of a non-existent line number. The resultant output was: plugin:obsidian-tasks-plugin:17605 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'includes') at eval (plugin:obsidian-tasks-plugin:17605:14) at Generator.next (<anonymous>) at fulfilled (plugin:obsidian-tasks-plugin:173:24)
claremacrae
added
the
scope: data integrity
This was referenced Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This prevents an exception if toggling in unsaved file in Reading mode.
See the comment #1680 (comment).
If lines had been deleted from a file, and it was not yet saved when user then toggled a line near the end of the file in Reading mode, there could be an access of a non-existent line number.
The resultant output was:
Motivation and Context
Another step in fixing outlier conditions in toggling tasks in Reading view
How has this been tested?
By adding a test which showed the problem behaviour, before the fix was applied.
Screenshots (if appropriate)
Types of changes
Changes visible to users:
fix- non-breaking change which fixes an issue)Internal changes:
test- additions and improvements to unit tests and the smoke tests)Checklist
yarn run lint.Terms