fix: Allow filename filters to contain parentheses #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…always list in the field reators. obsidian-tasks-group#1852
claremacrae
added a commit
to ilandikov/obsidian-tasks
that referenced
this pull request
Apr 24, 2023
claremacrae
added a commit
that referenced
this pull request
Apr 24, 2023
* refactor: add FolderField class for folder grouping * refactor: add RootField class for root grouping * refactor: add BacklinkField class for backlink grouping * refactor: remove old grouping * refactor: rename the famous 'parseGroupBy' * test: test: check grouper.property on new fields * docs: Document root and folder filtering Co-Authored-By: Ilyas Landikov <93825870+ilandikov@users.noreply.github.com> * fix: Disable filtering by backlink - use filename and heading instead Co-Authored-By: Ilyas Landikov <93825870+ilandikov@users.noreply.github.com> * refactor: Shorten variable name in tests Co-Authored-By: Ilyas Landikov <93825870+ilandikov@users.noreply.github.com> * refactor: Duplicate grouper implementation for backlink field Co-Authored-By: Ilyas Landikov <93825870+ilandikov@users.noreply.github.com> * fix: BacklinkField.value() no longer escapes characters Co-Authored-By: Ilyas Landikov <93825870+ilandikov@users.noreply.github.com> * fix: FolderField.value() no longer escapes characters Co-Authored-By: Ilyas Landikov <93825870+ilandikov@users.noreply.github.com> * fix: RootField.value() no longer escapes characters Co-Authored-By: Ilyas Landikov <93825870+ilandikov@users.noreply.github.com> * test: Add simple test for folder filter * test: Add failing tests for RootField.value() and filtering Git hooks disabled to allow commit and push. * test: fix test description * fix: remove the first '/' if present in the path * refactor: BacklinkField.grouper() refactor * test: additional test case on BacklinkField grouping * refactor: Folder and Root Field to groupers to call value() * refactor: Reorder new lines in FilterParser.ts to avoid #1907 conflict --------- Co-authored-by: Clare Macrae <github@cfmacrae.fastmail.co.uk>
claremacrae
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
I tried making RecurrenceField last and confirmed that I saw an error.
I don't think I would have understood how to fix it from the error alone, but the comments are very clear.
And I take your point about not being able to add a specific test because of the more general bug.
So very happy to approve this.
claremacrae
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed:
#1852
Description
This makes sure that
BooleanFieldis always last inFilterParser.If a field is added after
BooleanField, it shows a TypeScript compilation error.Motivation and Context
Fixes #1852
How has this been tested?
I tried the query described in the bug and it works as expected.
I also tried adding this to the tests, however this also caused the tests to catch #1500, which this PR does not fix, so I had to leave these tests out for now :(
Screenshots (if appropriate)
Types of changes
Changes visible to users:
fix- non-breaking change which fixes an issue)feat- non-breaking change which adds functionality)feat!!orfix!!- fix or feature that would cause existing functionality to not work as expected)docs- improvements to any documentation content for users)vault- improvements to the Tasks-Demo sample vault)contrib- any improvements to documentation content for contributors - see Contributing to Tasks)Internal changes:
refactor- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)test- additions and improvements to unit tests and the smoke tests)chore- examples include GitHub Actions, issue templates)Checklist
yarn run lint.Terms