generated from obsidianmd/obsidian-sample-plugin
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Automate content generation of some Priority docs #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it handles files with emojis correctly, unlike Araxis Merge and Beyond Compare.
This does actually fix a couple of whitespace inconsistencies in the exiting files.
claremacrae
added
scope: documentation
Improvements or additions to documentation
type: internal
Only regards development or contributing
labels
Jun 2, 2023
claremacrae
changed the title
chore: Automate content generation of Priority docs
chore: Automate content generation of some Priority docs
Jun 2, 2023
@ilandikov You might be interested in this as:
|
Looks good =) So the idea here is to use approvals as snippets for docs? Did I get it right? |
Yes, nice summary. Also for including in markdown files in the Test Vault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
scope: documentation
Improvements or additions to documentation
type: internal
Only regards development or contributing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
Use approval test files as snippets for docs and sample markdown files.
Background:
Detail
User visible changes:
Priority
emojis are now machine-generated in:Code changes:
PriorityField
to convertPriority
enum values to stringTests
tests/TaskSerializer/DocsSamplesForTaskFormats.test.ts
generates*.approved.md
files showing howPriority
values are represented in Emoji and dataview file formats.withAllPriorities()
is exported, and now includes a useful description for each task, so the tasks are suitable for inclusion in documentationtests/TestingTools/VerifyMarkdownTable.ts
now use Visual Studio Code's diff tool for showing and approving differences in approval test filesNotes
Motivation and Context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Changes visible to users:
docs
- improvements to any documentation content for users)vault
- improvements to the Tasks-Demo sample vault)Internal changes:
refactor
- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)test
- additions and improvements to unit tests and the smoke tests)Checklist
yarn run lint
.Terms