fix: Prevent default action when clicking the postpone button

[Cito]

Description

When clicking the "postpone" button (a feature introduced in version 5.3.0), then the default behavior of the associated click event should be suppressed.

Motivation and Context

If the task query appears in a callout, then clicking the postpone button will also trigger opening the callout for editing. This default behavior appears in addition to the desired behavior of postponing the task and is not expected to happen.

Moreover, when right-clicking the button, in addition to the postpone-context-menu, the default context menu for editing the callout will also appear on top of it. This PR fixes this problem as well. The default menu now only appears when right-clicking the callout outside of the postpone button.

Fixes #2512

How has this been tested?

• Manual testing
• Obsidian 1.5.0 and Tasks 5.3.0
• using the markdown shown in the issue

Types of changes

Changes visible to users:

• Bug fix (prefix: fix - non-breaking change which fixes an issue)
• New feature (prefix: feat - non-breaking change which adds functionality)
• Breaking change (prefix: feat!! or fix!! - fix or feature that would cause existing functionality to not work as expected)
• Documentation (prefix: docs - improvements to any documentation content for users)
• Sample vault (prefix: vault - improvements to the Tasks-Demo sample vault)
• Contributing Guidelines (prefix: contrib - any improvements to documentation content for contributors - see Contributing to Tasks)

Internal changes:

• Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
• Tests (prefix: test - additions and improvements to unit tests and the smoke tests)
• Infrastructure (prefix: chore - examples include GitHub Actions, issue templates)

Checklist

• My code follows the code style of this project and passes yarn run lint.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• My change has adequate Unit Test coverage.

Terms

• My contribution follow this project's contributing guide
• I agree to follow this project's Code of Conduct

[claremacrae]

Crikey, that was quick.

I've edited the description to the following, so GitHub will auto-close the issue when this is merged... so that I don't have to remember to do that...

Fixes #2512

[claremacrae]

Will review as soon as I have time...

[Cito]

I have now extended the scope a bit to also cover right-clicks in addition to the left-clicks.

[claremacrae]

Moreover, when right-clicking the button, in addition to the postpone-context-menu, the default context menu for editing the callout will also appear on top of it. This PR fixes this problem as well. The default menu now only appears when right-clicking the callout outside of the postpone button.

Testing the behaviour before the fix, I cannot reproduce the above.

For me, on Mac, in Live Preview, right-clicking on the Postpone button only shows the postpone menu.

[claremacrae]

Just to note that my understanding of this comment in #2517 suggests that this code may be changed later...

But I'm merging this PR anyway, as it is a definite improvement in behaviour, and also it exists.