refactor: extract QueryLayoutOptions from LayoutOptions #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claremacrae
reviewed
Dec 19, 2023
Manual operation. Automated refactoring not available, probably due to optional parameters
|
Smoke tests are good, added link for reference. |
claremacrae
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extract QueryLayoutOptions from LayoutOptions.
Motivation and Context
Starting to think about implementing issues such as #848 #2380 #2198
Separate concerns between options for task & query rendering.
How has this been tested?
Unit tests + smoke tests (https://github.com/obsidian-tasks-group/obsidian-tasks/actions/runs/7263529954)
Types of changes
Internal changes:
refactor- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)test- additions and improvements to unit tests and the smoke tests)Checklist
yarn run lint.Terms