fix: group by [date] now puts Invalid [date] date as first heading
#2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heading That is, with the build in date-grouping facility: 1. Invalid dates are in the first group 2. The field name is now included in the group name, which helps with identifying errors. This fixes #2591, for built-in date-grouping code.
#2591 is fixed. And I realised that my 'Default sort order' was wrong, as whether tasks are overdue affects the sort order.
claremacrae
changed the title
group by [date] now Invalid [date] date as first headinggroup by [date] now puts Invalid [date] date as first heading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make invalid dates more prominent in
group by dueand friends.Motivation and Context
How has this been tested?
Fixes #2591.
Screenshots (if appropriate)
Types of changes
Changes visible to users:
fix- non-breaking change which fixes an issue)docs- improvements to any documentation content for users)vault- improvements to the Tasks-Demo sample vault)Internal changes:
test- additions and improvements to unit tests and the smoke tests)Checklist
yarn run lint.Terms