Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable reading of high priority emoji with Variant Selector 16 appended #2695

Merged
merged 2 commits into from Mar 7, 2024

Conversation

claremacrae
Copy link
Collaborator

Description

Fix parsing of Priority emoji with Variant Selector 16 appended.

Motivation and Context

Fixes #2273.

How has this been tested?

  • New tests, initially failing.
  • Manual exploratory testing - confirming I could reproduce the problem behaviour before the fix, and that it was then behaving correctly afterwards.

Screenshots (if appropriate)

None.

Types of changes

Changes visible to users:

  • Bug fix (prefix: fix - non-breaking change which fixes an issue)

Internal changes:

  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Checklist

Terms

@claremacrae claremacrae added scope: emojis and signifiers Anything to do with emojis and signifiers scope: parsing markdown See also 'scope: global filter' labels Mar 7, 2024
@claremacrae claremacrae merged commit 7a12bbb into main Mar 7, 2024
2 checks passed
@claremacrae claremacrae deleted the fix-priority-with-VS16 branch March 7, 2024 22:16
@claremacrae claremacrae changed the title Fix priority with vs16 fix: Enable reading of high priority emoji with Variant Selection 16 appended Mar 7, 2024
@claremacrae claremacrae changed the title fix: Enable reading of high priority emoji with Variant Selection 16 appended fix: Enable reading of high priority emoji with Variant Selector 16 appended Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: emojis and signifiers Anything to do with emojis and signifiers scope: parsing markdown See also 'scope: global filter'
Projects
Status: 🎉 Released
Development

Successfully merging this pull request may close these issues.

Manual 'double up' arrow doesn't change task priority if followed by Variant Selector
1 participant