Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable Tasks to read "no entry" emoji from Emoji Shortcodes plugin #2696

Merged
merged 3 commits into from Mar 7, 2024

Conversation

claremacrae
Copy link
Collaborator

Description

Enable Tasks to read dependsOn emoji - ⛔ - that do not have the Variant Selector 16 (VS16) character.

That invisible character was accidentally included in the Tasks plugin source code, meaning Tasks would only parse dependsOn values with that character.

Note: This does not yet stop Tasks writing out VS16 for this emoji - I will do that as a separate PR as it's quite a large change.

Motivation and Context

Fix #2693.

How has this been tested?

  • Adding new tests, which initially failed
  • Exploratory testing to confirm that I could reproduce the bug before the fix, and that it was fixed afterwars

Screenshots (if appropriate)

Types of changes

Changes visible to users:

  • Bug fix (prefix: fix - non-breaking change which fixes an issue)

Internal changes:

  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Checklist

Terms

@claremacrae claremacrae added scope: parsing markdown See also 'scope: global filter' scope: emojis and signifiers Anything to do with emojis and signifiers labels Mar 7, 2024
@claremacrae claremacrae merged commit 38782c2 into main Mar 7, 2024
2 checks passed
@claremacrae claremacrae deleted the fix-dependsOn-without-vs16 branch March 7, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: emojis and signifiers Anything to do with emojis and signifiers scope: parsing markdown See also 'scope: global filter'
Projects
Status: 🎉 Released
Development

Successfully merging this pull request may close these issues.

Blocking query doesn't recognize "no entry" emoji from Emoji Shortcodes plugin
1 participant