Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add Edit Task modal snapshot test #2705

Merged
merged 4 commits into from Mar 17, 2024

Conversation

ilandikov
Copy link
Collaborator

Description

Add HTML snapshot test to verify/void changes in the Edit Task modal.

Motivation and Context

Have a "state" test of the task modal. So far we had only "action" tests - task editing (field change -> changed task) & task rendering (task -> field with correct task data).

How has this been tested?

Snapshot test =)

Types of changes

  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change has adequate Unit Test coverage.

Terms

@claremacrae claremacrae merged commit 105eeb1 into obsidian-tasks-group:main Mar 17, 2024
1 check passed
@claremacrae claremacrae added scope: user interface Changes to parts of UI other the Edit task modal. See also "scope: edit task" type: internal Only regards development or contributing labels May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: user interface Changes to parts of UI other the Edit task modal. See also "scope: edit task" type: internal Only regards development or contributing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants