Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'explain' omitted the instruction line in some Boolean expressions #2719

Merged
merged 5 commits into from Mar 19, 2024

Conversation

claremacrae
Copy link
Collaborator

Description

Fix the explain output for filters inside Boolean expressions, where the filter's explanation was more than a single line.

Previously, the source line was not displayed in that situation, and now it is.

Motivation and Context

Fix #2707

How has this been tested?

  • Fix the failing test that I added in 0328f49 to demonstrate this bug.
  • Update the results of a few existing tests.
  • Exploratory testing.

Screenshots (if appropriate)

image

Types of changes

Changes visible to users:

  • Bug fix (prefix: fix - non-breaking change which fixes an issue)
  • Documentation (prefix: docs - improvements to any documentation content for users)

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Checklist

Terms

@claremacrae claremacrae added scope: filters Additions and modifications to the search filters scope: explain About the `explain` instruction which generates explanations of tasks query blocks labels Mar 19, 2024
@claremacrae claremacrae changed the title Fix explain filters in booleans fix: 'explain' omitted the instruction line in some Boolean expressions Mar 19, 2024
@claremacrae claremacrae merged commit 4a1a461 into main Mar 19, 2024
2 checks passed
@claremacrae claremacrae deleted the fix-explain-filters-in-booleans branch March 19, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: explain About the `explain` instruction which generates explanations of tasks query blocks scope: filters Additions and modifications to the search filters
Projects
None yet
1 participant