Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Introduce BooleanDelimiters class #2754

Merged
merged 9 commits into from Apr 7, 2024

Conversation

claremacrae
Copy link
Collaborator

@claremacrae claremacrae commented Apr 7, 2024

Description

A pure refactoring:

  • Add class BooleanDelimiters that will grow to manage tracking of (...) and "..." in Boolean instructions
  • BooleanField now has a constructor which uses BooleanDelimiters.allSupportedDelimiters()
  • Add checkRegExpsIdentical() to aid refactoring regular expressions
  • Add multiple tests to BooleanField.test.ts

Motivation and Context

Preparing to work on:

How has this been tested?

  • Unit tests
  • Exploratory testing

Types of changes

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change has adequate Unit Test coverage.

Terms

@claremacrae claremacrae added scope: query logic Boolean combinations of filters - and, or, not type: internal Only regards development or contributing labels Apr 7, 2024
@claremacrae claremacrae merged commit bd93fe5 into main Apr 7, 2024
2 checks passed
@claremacrae claremacrae deleted the refactor-booleans-step1 branch April 7, 2024 21:06
@claremacrae claremacrae changed the title Refactor booleans step1 refactor: Introduce BooleanDelimiters class Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: query logic Boolean combinations of filters - and, or, not type: internal Only regards development or contributing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant