fix: allow Boolean filters such as "description includes abc" #2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was an unreported bug, in a deprecated feature, found during my recent experimental work on BooleanField.
claremacrae
added
the
scope: query logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an unreported bug that whilst single-case Boolean filters like this worked:
ones like this did not:
When I fixed #1170, I only fixed it for
(...)and not for"...".Motivation and Context
()and""consistent in this area, to simplify later steps in improving Boolean filtering code.How has this been tested?
Types of changes
Changes visible to users:
fix- non-breaking change which fixes an issue)Internal changes:
test- additions and improvements to unit tests and the smoke tests)Checklist
yarn run lint.Terms