Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support square brackets and curly braces to surround Boolean sub-expressions #2763

Merged
merged 7 commits into from Apr 9, 2024

Conversation

claremacrae
Copy link
Collaborator

Description

Support square brackets ([...]) and curly braces ({...}) to surround Boolean sub-expressions.

Note: more improvements are coming so I am not updating the documentation yet.

Motivation and Context

To add some alternatives to (...) and "...", for when a required filter ends with either ) or ", which would otherwise be treated as part of the Boolean logic rather than the filter.

How has this been tested?

  • Automated tests
  • Exploratory testing

Screenshots (if appropriate)

Example new lines:

[filter by function task.description.includes('a')] AND [description includes "hello world"]
{filter by function task.description.includes('a')} AND {description includes "hello world"}

Types of changes

Changes visible to users:

  • New feature (prefix: feat - non-breaking change which adds functionality)
  • Documentation (prefix: docs - improvements to any documentation content for users)

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    • Will be done later
  • My change has adequate Unit Test coverage.

Terms

@claremacrae claremacrae added the scope: query logic Boolean combinations of filters - and, or, not label Apr 9, 2024
@claremacrae claremacrae merged commit 27ea6be into main Apr 9, 2024
2 checks passed
@claremacrae claremacrae deleted the add-boolean-delimiters branch April 9, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: query logic Boolean combinations of filters - and, or, not
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant