Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reorder CSS classes in EditTasks.scss #2793

Merged

Conversation

ilandikov
Copy link
Collaborator

Description

  • Order CSS classes by their appearance in EditTask.svelte
  • Pure refactoring, no change in behaviour

Motivation and Context

  • Make changes easy in the Edit Task modal
  • Prepare to extract repeated behaviour in the Edit Task modal

How has this been tested?

Visual test in demo vault.

Types of changes

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change has adequate Unit Test coverage.
    • No unit testing on CSS code

Terms

Copy link
Collaborator

@claremacrae claremacrae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was really easy to follow by stepping through the small commits on my phone.

Thanks!

@claremacrae claremacrae merged commit 5e18f2a into obsidian-tasks-group:main May 1, 2024
1 check passed
@claremacrae claremacrae added the scope: edit task The Create or edit task modal/dialog label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: edit task The Create or edit task modal/dialog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants