Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean EditTask.scss #2799

Conversation

ilandikov
Copy link
Collaborator

@ilandikov ilandikov commented May 3, 2024

Description

Compilation of cleanup commits:

  • Remove unused classes (Absent in HTML/Svelte code)
  • Replace margin & line-height properties with more suitable grid-* options
  • Remove some unused properties that have no impact on any view

You may notice on the screenshots that the modal became a bit smaller, more compact. This is due to a slight difference in the spacing between the some blocks. So this is not exactly a pure refactoring, however adjusting this spacing was done in a suboptimal way currently (using fixed margins, different ways to render blocks in several places). So I will make that adjustable later on after further refactoring in a compact way.

Motivation and Context

Prepare for extraction of components from Svelte & CSS code

How has this been tested?

Visual test in demo vault of each Edit Task modal view (different widths)

Screenshots

Before After
Снимок экрана 2024-05-03 в 13 46 26 Снимок экрана 2024-05-03 в 14 03 54

Types of changes

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change has adequate Unit Test coverage.
    • No unit testing on CSS code

Terms

@ilandikov ilandikov marked this pull request as draft May 3, 2024 07:59
@ilandikov ilandikov marked this pull request as ready for review May 3, 2024 08:06
@ilandikov ilandikov added the scope: edit task The Create or edit task modal/dialog label May 3, 2024
@claremacrae claremacrae merged commit 9b5a867 into obsidian-tasks-group:main May 3, 2024
1 check passed
@claremacrae
Copy link
Collaborator

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: edit task The Create or edit task modal/dialog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants