generated from obsidianmd/obsidian-sample-plugin
-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: clean EditTask.scss
#2799
Merged
claremacrae
merged 12 commits into
obsidian-tasks-group:main
from
ilandikov:refactor-clean-EditTask-CSS-props
May 3, 2024
Merged
refactor: clean EditTask.scss
#2799
claremacrae
merged 12 commits into
obsidian-tasks-group:main
from
ilandikov:refactor-clean-EditTask-CSS-props
May 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class is absent in the project
This class is absent in the project
claremacrae
approved these changes
May 3, 2024
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compilation of cleanup commits:
margin
&line-height
properties with more suitablegrid-*
optionsYou may notice on the screenshots that the modal became a bit smaller, more compact. This is due to a slight difference in the spacing between the some blocks. So this is not exactly a pure refactoring, however adjusting this spacing was done in a suboptimal way currently (using fixed margins, different ways to render blocks in several places). So I will make that adjustable later on after further refactoring in a compact way.
Motivation and Context
Prepare for extraction of components from Svelte & CSS code
How has this been tested?
Visual test in demo vault of each Edit Task modal view (different widths)
Screenshots
Types of changes
Internal changes:
refactor
- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)Checklist
yarn run lint
.Terms