Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add some tests for dependency suggestions #2806

Merged
merged 58 commits into from
May 6, 2024

Conversation

claremacrae
Copy link
Collaborator

@claremacrae claremacrae commented May 6, 2024

Description

Motivation and Context

  • Replace an Obsidian-specific string.contains() with string.includes() which is available when run via tests.
  • Add some initial tests to capture the behaviour of auto-suggest facilities added in feat: Add Auto Suggest for Task dependencies #2771.
  • Add a fake implementation of prepareSimpleSearch() - with its own tests - so that I could test suggestions made for the dependsOn field.

How has this been tested?

  • Exploratory testing to confirm the actual behaviours of the tests I've added
  • Automated tests

Types of changes

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change has adequate Unit Test coverage.

Terms

This involved making it return the suggestions, for further testing
@claremacrae claremacrae added type: internal Only regards development or contributing scope: auto-suggest The pop-up menu that helps with editing tasks directly in markdown notes scope: task dependencies Anything to do with making tasks aware of other tasks labels May 6, 2024
@claremacrae claremacrae requested a review from ilandikov May 6, 2024 14:56
@claremacrae
Copy link
Collaborator Author

Hi Ilyas, FYI.... I'll merge this later anyway, as I need to share it with the author of #2771 - but low priority suggestion - if there is anything really unclear I would appreciate any quick feedback you could offer...

@claremacrae claremacrae merged commit fd391f2 into main May 6, 2024
2 checks passed
@claremacrae claremacrae deleted the test-dependency-suggestions branch May 6, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: auto-suggest The pop-up menu that helps with editing tasks directly in markdown notes scope: task dependencies Anything to do with making tasks aware of other tasks type: internal Only regards development or contributing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant