generated from obsidianmd/obsidian-sample-plugin
-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add some tests for dependency suggestions #2806
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This involved making it return the suggestions, for further testing
To eliminate source of confusion.
claremacrae
added
type: internal
Only regards development or contributing
scope: auto-suggest
The pop-up menu that helps with editing tasks directly in markdown notes
scope: task dependencies
Anything to do with making tasks aware of other tasks
labels
May 6, 2024
Hi Ilyas, FYI.... I'll merge this later anyway, as I need to share it with the author of #2771 - but low priority suggestion - if there is anything really unclear I would appreciate any quick feedback you could offer... |
Code review feedback.
Code review feedback.
claremacrae
commented
May 6, 2024
15 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
scope: auto-suggest
The pop-up menu that helps with editing tasks directly in markdown notes
scope: task dependencies
Anything to do with making tasks aware of other tasks
type: internal
Only regards development or contributing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
string.contains()
withstring.includes()
which is available when run via tests.prepareSimpleSearch()
- with its own tests - so that I could test suggestions made for the dependsOn field.How has this been tested?
Types of changes
Internal changes:
refactor
- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)test
- additions and improvements to unit tests and the smoke tests)Checklist
yarn run lint
.Terms