Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Test and improve behaviour of auto-suggest with dependencies #2826

Merged
merged 41 commits into from
May 15, 2024

Conversation

claremacrae
Copy link
Collaborator

@claremacrae claremacrae commented May 15, 2024

Description

I'm using the new auto-suggest for ID and dependsOn in my own vault, and it's incredibly valuable.

Before release, I wanted to add tests to make sure I understand the code.

Along the way, I improved a couple of behaviours:

  • 99129ea - allow additional dependencies after ids with hyphen and underscore
  • bcee94a - correct the search for blocking tasks to use exact id match, not substring

Motivation and Context

Getting this facility ready for release

How has this been tested?

  • Adding new tests
  • Manual exploratory testing

Screenshots (if appropriate)

Types of changes

Changes visible to users:

  • Bug fix (prefix: fix - non-breaking change which fixes an issue)

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Checklist

Terms

Preparing to extract a variable.
Preparing to remove some duplication.
@claremacrae claremacrae added scope: auto-suggest The pop-up menu that helps with editing tasks directly in markdown notes scope: task dependencies Anything to do with making tasks aware of other tasks labels May 15, 2024
@claremacrae claremacrae merged commit c4acaa8 into main May 15, 2024
2 checks passed
@claremacrae claremacrae deleted the fix-dependency-auto-suggest branch May 15, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: auto-suggest The pop-up menu that helps with editing tasks directly in markdown notes scope: task dependencies Anything to do with making tasks aware of other tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant