Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'Apply' in 'Create or edit Task' started failing earlier today #765

Conversation

claremacrae
Copy link
Collaborator

Description

Downgrade esbuild from 0.14.43 to 0.13.15.

esbuild 0.14.0 was a breaking change, so go for the last release on 0.13.x for now.

Motivation and Context

Fixes #764: Clicking 'Apply' in 'Create or edit Task' fails with console error.

How has this been tested?

  1. Edit the rebuild version
  2. Delete node_modules
  3. yarn install
  4. yarn dev
  5. Copy the created files to my test vault
  6. Restart Obsidian
  7. Confirm that the Apply button now works as expected

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project and passes yarn run lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change has adequate Unit Test coverage.

By creating a Pull Request you agree to our Code of Conduct. For further guidance on contributing please see contributing guide

Fixes obsidian-tasks-group#764: Clicking 'Apply' in 'Create or edit Task' fails with console error.
@claremacrae claremacrae merged commit 6634c2d into obsidian-tasks-group:main Jun 11, 2022
@claremacrae claremacrae deleted the fix-create-or-edit-task-in-dev-version branch June 11, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking 'Apply' in 'Create or edit Task' fails with console error
1 participant