Add SSL connection parameter for Schema registry #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ties to Kafka Avro Deserializer class.
…instead of the value 1000 for parameter identityMapCapacity.
|
Why hasn't this pull request been merged yet? |
davideicardi
requested changes
Dec 28, 2021
| @@ -76,6 +76,16 @@ | |||
| <groupId>org.projectlombok</groupId> | |||
| <artifactId>lombok</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.apache.kafka</groupId> | |||
There was a problem hiding this comment.
From my understending Kafdrop uses spring-kafka. So I think that to update Kafka clients we have to update spring-kafka.
Is required for this PR to update kafka-clients? If not I suggest to remove this update.
| <version>2.6.0</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.freemarker</groupId> |
There was a problem hiding this comment.
Why do you have added this dependency? If not strictly required for the PR I suggest to remove it (and in case create another PR ...).
| @@ -274,6 +274,9 @@ docker run -d --rm -p 9000:9000 \ | |||
| |`KAFKA_PROPERTIES_FILE`|Internal location where the Kafka properties file will be written to (if `KAFKA_PROPERTIES` is set). Defaults to `kafka.properties`. | |||
| |`KAFKA_TRUSTSTORE_FILE`|Internal location where the truststore file will be written to (if `KAFKA_TRUSTSTORE` is set). Defaults to `kafka.truststore.jks`. | |||
| |`KAFKA_KEYSTORE_FILE` |Internal location where the keystore file will be written to (if `KAFKA_KEYSTORE` is set). Defaults to `kafka.keystore.jks`. | |||
| |`SCHEMAREGISTRY_PROPERTIES`|Additional properties to configure the schema registry connection (base-64 encoded). Provides keystore/trustore location and password. | |||
| |`SCHEMAREGISTRY_TRUSTSTORE`|Certificate for schema registry authentication (base-64 encoded). Required for TLS/SSL. | |||
| |`SCHEMAREGISTRY_KEYSTORE` |Private key for mutual TLS authentication (base-64 encoded). | |||
|
|
|||
There was a problem hiding this comment.
It could also useful to add a simple documentation on how to configure these properties and when is necessary?
Bert-R
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes to Kafdrop so that it can connect to a secure Schema Registry endpoint.
Added the following parameters:
These work similar to