Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip topic when a TopicAuthorizationException occurs #341

Merged
merged 1 commit into from Jan 31, 2022
Merged

skip topic when a TopicAuthorizationException occurs #341

merged 1 commit into from Jan 31, 2022

Conversation

jorkzijlstra
Copy link
Contributor

@jorkzijlstra jorkzijlstra commented Jan 28, 2022 •
edited by davideicardi

Fix #208

When a TopicAuthorizationException occurs we just skip the Topics and continue loading the page

davideicardi
davideicardi requested changes Jan 28, 2022
View reviewed changes
Copy link
Collaborator

@davideicardi davideicardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Maybe we should at least write something in the log?
Can you explan me why the previous printAcls function is not working?

@jorkzijlstra jorkzijlstra force-pushed the feature/skip-unauthorised-topics branch from e434dfa to 5845d37 Compare January 28, 2022 20:00
@jorkzijlstra
Copy link
Contributor Author

@davideicardi printAcls is off course working and actually handy to keep. If your topic doesn't show your can see that in the logs. So I have put it back and added just the return of an empty Map

davideicardi
davideicardi approved these changes Jan 28, 2022
View reviewed changes
Copy link
Collaborator

@davideicardi davideicardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davideicardi davideicardi merged commit 60d9db2 into obsidiandynamics:master Jan 31, 2022
@jorkzijlstra jorkzijlstra deleted the feature/skip-unauthorised-topics branch January 31, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davideicardi davideicardi davideicardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to skip or authorize not authorized to access topics
2 participants
@jorkzijlstra @davideicardi