Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-select a descriptor file equal to topic name if available #383

Merged
merged 1 commit into from Jun 3, 2022

Conversation

gebinic
Copy link
Contributor

@gebinic gebinic commented May 31, 2022

No description provided.

Copy link
Collaborator

@davideicardi davideicardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!
Can you please describe a little bit the feature?

The assumption is that there is a descriptor file with the same name of the topic?

@gebinic
Copy link
Contributor Author

gebinic commented Jun 1, 2022

The assumption is that there is a descriptor file with the same name of the topic?

Yes! This is a known limitation of this convenience feature. If such a descriptor file could not be found, no one will be pre-selected in kafdrop's web ui, i.e the currently known behavior takes place.

Lets assume a kafka topic name is "example" and there is a list of descriptor files "example.desc" and "example2.desc". When a developer requests the kafka messages, the corresponding method in the controller class compares each descriptor file name with the given topic name. If there is a match, this descriptor file will be pre-selected in kafdrop's web ui. Otherwise, an arbitrary descriptor file is pre-select (default behavior).

@davideicardi davideicardi changed the title Pre-select a descriptor file for a specific topic if available Pre-select a descriptor file equal to topic name if available Jun 1, 2022
@davideicardi davideicardi merged commit 9aeb242 into obsidiandynamics:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants