Adding support for SchemaRegistryConfiguration(truststore password and location) and sasl jaas config in KafkaConfiguration #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- truststoreLocation - truststorePassword Adding support for KafkaConfiguration: - saslJaasConfig Increasing MessageController maxOffset size since 1000 seems to be easily supported.
|
Adding support for SchemaRegistryConfiguration new parameters:
Increasing MessageController maxOffset size since 1000 seems to be easily supported. |
GoncaloPT
changed the title
|
@GoncaloPT Thank you! Can you please just use the previous code indentation configuration? It looks like many changes are only for different spaces ... |
Hello @davideicardi. It was intellij defaults, but i will try to revert them and add some more description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increasing MessageController maxOffset size since 1000 seems to be easily supported.