Update to JDK 17 and SpringBoot 3 #482
Conversation
mehdihasan
commented
Mar 11, 2023
mehdihasan
commented
- Use of JDK 17
- Migration from SpringFox to SpringDoc OpenAPI
* Use of JDK 17 * Migration from SpringFox to SpringDoc OpenAPI
|
Thank you @mehdihasan ! This is a huge step forward. From what you can see there is any drawback or problems with this new versions? I see a problem in the CI. Do you know what is wrong? (it could be unrelated...) |
|
Hi @davideicardi, thanks for looking into this. I needed to upgrade the project to SpringBoot 3 - which ended up to migration from Swagger to OpenAPI as well - so it became a huge change. I thought it might be something helpful for others as well. Initially my idea was to push it into a branch named springboot-3.0.4. However, I can't be able to create the branch - so ended up raising a pull request in master. It looks like the CI script is using JDK 11 to compile the code - which ended up into the failure. I have compiled the code with JDK 17. I will try the JDK 11 and come back soon. |
@mehdihasan May I suggest to update the workflow files in .github/workflows instead? Just upgrade Java to 17. That should make the build of this PR pass. |
|
Instead, just add the updates of |
* Use of JDK 17 * Migration from SpringFox to SpringDoc OpenAPI * Update git workflow JDK version to 17
|
@davideicardi The PR build now waits for your approval (to ensure someone is not making malicious PRs through workflow updates). |
mehdihasan
changed the title
There was a problem hiding this comment.
Great improvement, appreciated!
I've added a few small comments.
When I saw this the first time, I didn't feel it deserves a major version upgrade as it would remain strictly backward compatible, but now I see that is not exactly true:
- People that run the JAR directly will need Java 17
- People that use the OpenAPI specification will need use a different endpoint and a new spec version.
So, a major version upgrade makes sense to me.
* Update tags to the controllers * Update spring-doc version to 2.0.4 * Rename SwaggerConfiguration to OASConfiguration * Update documentation on OpenAPI Specification * Springfox libraries don't work with Spring Boot 3.x.x, and it is not being updated for last ~3 years. It is recommended to migrate to Springdoc.
* Springdoc enabling and disabling is part of the library now
There was a problem hiding this comment.
Looks good. Thanks for the contribution!
@davideicardi If you're OK with it, it can be merged. See the comments about Swagger UI and about compatibility.
This change will bump the version of the kafdrop image. It includes numerous Dependency updates as well as bugfixes, and security patching. Also includes some shiny new features such as: - Added Message Search functionality [#288](obsidiandynamics/kafdrop#288) - Enabled dependabot to update deps and base image tag [#404](obsidiandynamics/kafdrop#404) **Breaking Changes**: - Update to JDK 17 and SpringBoot 3 in upstream [#482](obsidiandynamics/kafdrop#482) For the complete list of changes see: [Releases](https://github.com/obsidiandynamics/kafdrop/releases) [Comparing Changes](obsidiandynamics/kafdrop@3.30.0...4.0.1)
