Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chart-release actions workflow #630

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Add chart-release actions workflow #630

merged 1 commit into from
Apr 3, 2024

Conversation

FieteO
Copy link
Contributor

@FieteO FieteO commented Apr 3, 2024 •
edited
Loading

This PR adds a release workflow as described on the official helm website.
I can't really test this though, so I am not sure if this works

Related: #236, #357

Bert-R
Bert-R approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@Bert-R Bert-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Let's try whether it works. I see the installation of Helm is not included, that might cause an issue.

@Bert-R Bert-R merged commit 526c398 into obsidiandynamics:master Apr 3, 2024
1 check passed
@Bert-R
Copy link
Collaborator

Bert-R commented Apr 3, 2024

@FieteO It didn't do anything. This is the output:

Looking up latest tag...
Discovering changed charts since '4.0.1'...
Nothing to do. No chart changes detected.

I think it's because the folder with the chart is called /chart while the documentation states it should be /charts. Do you mind adding a PR that sets this through the charts_dir option?

@florianbachmann
Copy link
Contributor

Hello hello,
I tried to add the directive here:
#631
best regards,
Flori, friend of Fiete :-)

Bert-R pushed a commit that referenced this pull request Apr 3, 2024
@florianbachmann
try to fix "Add chart-release actions workflow #630" by using charts_…
7569e4a 
…dir: chart (#631)
Bert-R added a commit that referenced this pull request Apr 11, 2024
@Bert-R
Revert chart release workflow
80a1836 
This reverts #630 and #631
@Bert-R Bert-R mentioned this pull request Apr 11, 2024
Merged
Bert-R added a commit that referenced this pull request Apr 12, 2024
@Bert-R
Revert chart release workflow (#634)
f5e80c0 
This reverts #630 and #631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bert-R Bert-R Bert-R approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FieteO @Bert-R @florianbachmann