Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker configuration and steps #75

Merged
merged 3 commits into from
Jul 16, 2020

Conversation

OllieJC
Copy link
Contributor

@OllieJC OllieJC commented Jul 16, 2020

This PR aligns the Docker ports to the unfurl.ini (5000) and uses COPY instead of a volume mount, this makes it easier to run off the bat.

  • Tests pass
  • Appropriate changes to README are included in PR

(Coming from SANS DFIR Summit 😃 Great talk 👏)

Port 5000 is what the default unfurl.ini file uses.
Will replace the volume mount with `COPY` in the Dockerfile and use sed to replace host value.
Copy the unfurl.ini file instead of volume mount and set the host value to `0.0.0.0` using sed so that Docker works.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no User has not yet signed CLA label Jul 16, 2020
@OllieJC
Copy link
Contributor Author

OllieJC commented Jul 16, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes User has signed CLA and removed cla: no User has not yet signed CLA labels Jul 16, 2020
@obsidianforensics
Copy link
Owner

Awesome, thanks @OllieJC!

@obsidianforensics obsidianforensics merged commit 7bbd558 into obsidianforensics:master Jul 16, 2020
@obsidianforensics obsidianforensics self-assigned this Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes User has signed CLA
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants