-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Keep: unnecessary alias #65
Comments
@daledesilva I am not sure I understand the purpose of using keepJson.title.split('\n') for aliases. Can notes have multiple titles? |
Notes can have titles that are more than one line long, but I only noticed that accidentally. |
For |
With 1.1.0, it's |
Hmm ok, so we should probably ignore the title field altogether? What do you think @daledesilva? |
Definitely don't ignore the title, at least for file names. Notes can even be only a title. I don't think many people use multi line titles, you'd have to know and press shit enter, or a normal enter would take you to the note content when you input it. (Or you can just copy text there that has more lines.) |
The file name is created from what Keep exports as file names in the zip. If it's always some combination of flattened "title" field then it would make sense to ignore. |
I think that's what it is, yes, and if there's no title, it's the date instead. But I would not ignore it, unless you have some better mechanism for creating a file name or title. It makes a lot of sense to me, to have the OS friendly file name, and if it differs from the original, have an alias field with the original title with special characters if there were any. |
Ok so it makes sense to alias to |
Agree with all of this. That was my thinking when I did it. To reiterate
Note, on the original ticket question... |
Aliases should only be used when the title would be an invalid file name, otherwise it's just duplicated information. Now every note with a title has one.
Notes that don't have a title in Keep get a date title, but no alias, which is also weird.
The text was updated successfully, but these errors were encountered: