Fix failure to load on mobile #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, |
Mostly; a lot of the behaviors between macOS and iOS are shared - things like the command modifier key (instead of ctrl), and plus iOS browsers "pretend" to be macOS. If you want to test for desktop mac then you'd want to check |
lishid
approved these changes
Oct 19, 2023
src/main.ts
Outdated
| @@ -204,6 +204,7 @@ export default class ImporterPlugin extends Plugin { | |||
| authCallback: AuthCallback | undefined; | |||
|
|
|||
| async onload() { | |||
| console.log('a'); | |||
There was a problem hiding this comment.
This was probably not intentional?
lishid
reviewed
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #138 (sorry about that 🤦♂️)
sqlite-tag-spawnedimports a bunch ofnodemodules in the global scope. To avoid this, bundle a modified version ofsqlite-tag-spawned(similar to what is done withyarle) which only loads said modules on desktop.