Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneNote Bug Bounty - #177 #209

Merged
merged 10 commits into from Mar 28, 2024
Merged

Conversation

Copy link
Contributor

@tgrosinger tgrosinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @p3rid0t. Let me know if you have questions about any of these comments.

src/formats/onenote.ts Outdated Show resolved Hide resolved
src/formats/onenote.ts Outdated Show resolved Hide resolved
src/formats/onenote.ts Outdated Show resolved Hide resolved
src/formats/onenote.ts Outdated Show resolved Hide resolved
src/formats/onenote.ts Outdated Show resolved Hide resolved
src/formats/onenote.ts Outdated Show resolved Hide resolved
src/formats/onenote.ts Show resolved Hide resolved
src/formats/onenote.ts Outdated Show resolved Hide resolved
src/formats/onenote.ts Show resolved Hide resolved
src/formats/onenote.ts Show resolved Hide resolved
@p3rid0t
Copy link
Contributor Author

p3rid0t commented Mar 10, 2024

I just pushed a commit with fixes to the comments mentioned here. Sorry it took a while, hope you don't mind.

src/formats/onenote.ts Outdated Show resolved Hide resolved
src/formats/onenote.ts Outdated Show resolved Hide resolved
src/formats/onenote.ts Outdated Show resolved Hide resolved
@p3rid0t
Copy link
Contributor Author

p3rid0t commented Mar 23, 2024

Pushed another commit with the small type tweaks mentioned in the comments :)

@tgrosinger
Copy link
Contributor

Thanks @p3rid0t. I added another commit that applies some formatting fixes and a couple other tweaks to the method types that we were discussing.

I think this looks good to me now. Thank you.

@tgrosinger tgrosinger merged commit 6bccde0 into obsidianmd:master Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants