Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Blockquote Levels" plugin #1165

Merged
merged 3 commits into from Oct 7, 2022

Conversation

czottmann
Copy link
Contributor

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/czottmann/obsidian-blockquote-levels

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the tips in https://github.com/obsidianmd/obsidian-releases/blob/master/plugin-review.md and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@joethei joethei self-assigned this Sep 28, 2022
@joethei
Copy link
Collaborator

joethei commented Sep 28, 2022

Looks good.

You can remove obsidian from the ID, it's unnecessary.

@czottmann
Copy link
Contributor Author

@joethei

You can remove obsidian from the ID, it's unnecessary.

From manifest and package name, you mean? Will do, thanks for the suggestion (and the review)!

@joethei
Copy link
Collaborator

joethei commented Sep 28, 2022

From the manifest and in the PR here, the package name is used nowhere.

@czottmann czottmann reopened this Sep 28, 2022
@czottmann
Copy link
Contributor Author

Yo @joethei, I've updated the ID in both places as requested. Hope it's okay now!

@huyz
Copy link

huyz commented Oct 2, 2022

Looking forward to this plugin

@liamcain
Copy link
Collaborator

liamcain commented Oct 7, 2022

Instead of sorting the selections and performing the text changes one at a time, you could wrap them in a single transaction. That will make the changes atomic, so if the user presses "undo" all the changes will be rolled back at once.

(here's an example from the creases plugin)

@liamcain liamcain merged commit 62dbc62 into obsidianmd:master Oct 7, 2022
@czottmann
Copy link
Contributor Author

@liamcain

Instead of sorting the selections and performing the text changes one at a time, you could wrap them in a single transaction. That will make the changes atomic, so if the user presses "undo" all the changes will be rolled back at once.

(here's an example from the creases plugin)

Thanks for the suggestion! I'll add it in the next update as it's a good idea. :)

And thanks for merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants