Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ai-research-assistant to community-plugns.json #2218

Conversation

ericrallen
Copy link

@ericrallen ericrallen commented Jul 29, 2023

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/InterwebAlchemy/obsidian-ai-research-assistant

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux Don't have Obsidian installed on a Linux machine
    • Android (if applicable) Desktop Only due to Electron SafeStorage requirement for API keys
    • iOS (if applicable) Desktop Only due to Electron SafeStorage requirement for API keys
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the tips in https://github.com/obsidianmd/obsidian-releases/blob/master/plugin-review.md and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: InterwebAlchemy/obsidian-ai-research-assistant. If you are submitting from a GitHub org, you need to be a public member of the org.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@ericrallen
Copy link
Author

ericrallen commented Aug 10, 2023

@joethei I addressed your feedback and rebased my PR so that the plugin is the last entry in the Array again.

For ease of reference, this is the PR that addressed the issues you pointed out and some others I found in the updated guidelines you linked to: InterwebAlchemy/obsidian-ai-research-assistant#13

Specifically, this commit addresses your feedback and this commit addresses using the normalizePath() helper.

Also, I opened #2278 to update the link in the Plugin PR Review checklist to the docs you linked instead of the older docs that didn't mention some of the guidelines. It looks like #2209 already addresses the link.

@liamcain
Copy link
Collaborator

Added here: f6cdc0d

@liamcain liamcain closed this Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants