Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Tldraw #2430

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Add plugin: Tldraw #2430

merged 2 commits into from
Dec 18, 2023

Conversation

holxsam
Copy link
Contributor

@holxsam holxsam commented Sep 10, 2023

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/holxsam/tldraw-in-obsidian/

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@andradei
Copy link

Refers to request on: holxsam/tldraw-in-obsidian#4

@joethei
Copy link
Collaborator

joethei commented Sep 29, 2023

required changes

constructor(app: App, manifest: PluginManifest) {
This is not necessary, remove it.

name: "Toggle View Mode",
.setPlaceholder("Time Format")
Use sentence case in UI


suggestions/questions

const folder = vault.getAbstractFileByPathInsensitive(folderpath);
Why are you using the case-insensitive version here?

const timeFormatSetting = new Setting(containerEl)
There is the MomentFormatComponent that can be used to show the current time in the specified format.
here is a sample: https://github.com/joethei/obsidian-rss/blob/b600e2ead2505d58aa3e4c7898795bbf58fa3cdc/src/settings/FileCreationSettings.ts#L119C23-L139

@joethei joethei self-assigned this Sep 29, 2023
@joethei joethei added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Sep 29, 2023
@github-actions
Copy link

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 30 days unless there are any updates.

@github-actions github-actions bot added the stale label Oct 30, 2023
@0xdevalias
Copy link

@holxsam Any chance of getting the changes needed for this PR finished? Would be great to see it in the community plugins!

@github-actions github-actions bot removed the stale label Nov 13, 2023
@holxsam
Copy link
Contributor Author

holxsam commented Nov 13, 2023

@holxsam Any chance of getting the changes needed for this PR finished? Would be great to see it in the community plugins!

Yeah sorry I've been a bit busy, will knock out the changes this week forsure :)

@0xdevalias
Copy link

will knock out the changes this week forsure :)

@holxsam Awesome, appreciate it! :)

@holxsam
Copy link
Contributor Author

holxsam commented Nov 18, 2023

Hey @joethei, I removed the unnecessary contructor call, adjusted all text to be sentence case, and applied your suggestion to use the built-in moment component. The manifest version and release is now updated to 1.0.5.

const folder = vault.getAbstractFileByPathInsensitive(folderpath); Why are you using the case-insensitive version here?

I got that file utility function from the obsidian-excalidraw plugin where they had this issue: zsviczian/obsidian-excalidraw-plugin#658

Let me know if there are any more issues I need to fix.

@joethei joethei added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Nov 18, 2023
@github-actions github-actions bot changed the title Add Tldraw to community plugins Add plugin: Tldraw Dec 18, 2023
@liamcain
Copy link
Collaborator

Sorry for the delay! The plugin looks great, glad to have this finally merged in.

@liamcain liamcain merged commit 0656b09 into obsidianmd:master Dec 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants