Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Vault Name #3563

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Add plugin: Vault Name #3563

merged 1 commit into from
Jun 11, 2024

Conversation

gapmiss
Copy link
Contributor

@gapmiss gapmiss commented May 21, 2024

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/gapmiss/obsidian-vault-name

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions github-actions bot changed the title Add Vault Name plugin Add plugin: Vault Name May 21, 2024
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:You should not cast this, instead use a instanceof check to make sure that it's actually the adapter you expect.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot self-assigned this May 22, 2024
@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Ready for review and removed Ready for review Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels May 22, 2024
@ObsidianReviewBot ObsidianReviewBot removed their assignment May 22, 2024
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, assigning human for additional review.

@gapmiss
Copy link
Contributor Author

gapmiss commented Jun 2, 2024

@joethei I got to thinking about this plugin and the fact that it will only work with Obsidian version 1.6.0+. I have considered downgrading my install of Obsidian and see if I can make it work for pre-1.6.0 versions, but would rather just leave as is. How can I limit the plugin for only 1.6.0+? If I add the latest version of the API in the manifest.json would that only allow it to be installed for the targeted version(s)? Please advise and thank you.

@joethei
Copy link
Collaborator

joethei commented Jun 4, 2024

set the minAppVersion in the manifest to 1.6.0, then only versions after that will be able to install the latest version of your plugin.
You should also update the versions.json file, as Obsidian will check that file to find out which version of the plugin it should install if it's below 1.6.0

@joethei joethei merged commit 5f46c38 into obsidianmd:master Jun 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants