Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Substitutions #3564

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Add plugin: Substitutions #3564

merged 1 commit into from
Jun 11, 2024

Conversation

BambusControl
Copy link
Contributor

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/BambusControl/obsidian-substitutions

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Your latest version number is not valid. Only numbers and dots are allowed.
❌ Unable to find a release with the tag 0.1.0-NEXT. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@BambusControl
Copy link
Contributor Author

Fixed it..

@BambusControl BambusControl reopened this May 21, 2024
@github-actions github-actions bot changed the title Add "substitutions" community plugin Add plugin: Substitutions May 21, 2024
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, assigning human for additional review.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels May 22, 2024
@BambusControl
Copy link
Contributor Author

Thanks for the quick reply! I've fixed the issues.

  1. Set min obsidian version to 1.5.12

  2. Console logging is dropped via labeled statements for release builds. The released script will not log to the console---tested it out locally.

@BambusControl
Copy link
Contributor Author

Hey @joethei, the changes were implemented. Pinging you since it has been a week since. Thanks

@BambusControl
Copy link
Contributor Author

Hey @ObsidianReviewBot; I've fixed the issues

@joethei joethei added Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Jun 11, 2024
@joethei joethei merged commit 712e66e into obsidianmd:master Jun 11, 2024
1 check passed
@BambusControl
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants