Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Note Definitions #3572

Merged
merged 1 commit into from
May 27, 2024
Merged

Add plugin: Note Definitions #3572

merged 1 commit into from
May 27, 2024

Conversation

dominiclet
Copy link
Contributor

@dominiclet dominiclet commented May 23, 2024

I am submitting a new Community Plugin

Repo URL

https://github.com/dominiclet/obsidian-note-definitions
Link to my plugin:

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions github-actions bot changed the title Update community-plugins.json Add plugin: Note Definitions May 23, 2024
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:


Optional

[1]:Casting to any should be avoided as much as possible.


Do NOT open a new PR for re-validation.

@joethei
Copy link
Collaborator

joethei commented May 24, 2024

"minAppVersion": "0.15.0",
You are using newer API's, set this to the latest public build number.

logInfo("cmEditor object not found, will not handle vim events for definition dropdown");, logInfo("Cleaning dropdown elements");
Please avoid unnecessary logging. If you need it for debugging purposes, add a check to only log during development.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels May 24, 2024
@dominiclet
Copy link
Contributor Author

@joethei thanks for the review, I've updated "minAppVersion" to 1.5.12. logInfo() does not log by default unless a debug flag is being set. Anyway I've changed references to logInfo() to logDebug()

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels May 25, 2024
@joethei joethei merged commit 38c95b5 into obsidianmd:master May 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants